Fix bug with inner .Count(predicate) translation#477
Closed
SergeiPavlov wants to merge 2 commits into
Closed
Conversation
botinko
approved these changes
Apr 22, 2026
|
@SergeiPavlov I'm going to fix the root cause of this bug in the upcoming PR. And it's not something new. |
snaumenko-st
requested changes
Apr 23, 2026
snaumenko-st
left a comment
snaumenko-st
left a comment
There was a problem hiding this comment.
The replacement PR has been already merged, so there is no sense in merging this.
Moreover, this constitution of .Count(<filter>) with .Where(<filter>).Count() will prevent further aggregate fusion optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new DataObjects from Xtensive (starting
7.3.12in our version numbering)cannot translate inner
.Count(predicate)expressions like following:See the discussion: https://servicetitan.slack.com/archives/CLM7XAVLK/p1776720202265489?thread_ts=1776709176.616779&cid=CLM7XAVLK
This PR fixes it, translating as an equivalent sequence
.Where(predicate).Count()Also: